This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Improved performance of iterator of Utf8Array and BinaryArray (3-4x)
#427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgecarleitao
changed the title
Utf8Array and BinaryArray (3-4x)Utf8Array and BinaryArray (3-4x)
Codecov Report
@@ Coverage Diff @@
## main #427 +/- ##
=======================================
Coverage 80.78% 80.78%
=======================================
Files 372 372
Lines 22645 22639 -6
=======================================
- Hits 18294 18290 -4
+ Misses 4351 4349 -2
Continue to review full report at Codecov.
|
jorgecarleitao
force-pushed
the
fast_iter
branch
2 times, most recently
from
c76e4c2 to
150b469
Compare
jorgecarleitao
force-pushed
the
fast_iter
branch
from
150b469 to
194e17d
Compare
|
Good catch, @Dandandan , I also rebased incorrectly and removed the |
jorgecarleitao
force-pushed
the
fast_iter
branch
from
194e17d to
bd78970
Compare
|
Very nice perf. improvement! Could you explain what you did? I've been browsing a bit, but I can't find it yet. Is it this line? |
jorgecarleitao
force-pushed
the
fast_iter
branch
from
bd78970 to
4ea7607
Compare
jorgecarleitao
commented
Sep 20, 2021
|
|
||
| let slice = &self.values.as_slice()[offset..offset + length]; |
There was a problem hiding this comment.
this line @ritchie46
|
|
||
| &self.values[offset..offset + length] |
There was a problem hiding this comment.
this line @ritchie46
|
|
||
| &self.values[offset..offset + length] |
| let length = (offset_1 - offset).to_usize(); | ||
| let offset = offset.to_usize(); | ||
|
|
||
| let slice = &self.values.as_slice()[offset..offset + length]; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has implications on almost every kernel over these arrays, as well as users of the iterator.